Skip to content
This repository has been archived by the owner on Jan 9, 2023. It is now read-only.

feat(i18n): add translation resources #1668

Closed
wants to merge 20 commits into from
Closed

feat(i18n): add translation resources #1668

wants to merge 20 commits into from

Conversation

ocBruno
Copy link
Contributor

@ocBruno ocBruno commented Dec 11, 2019 •
edited
Loading

I plan on looking for bilingual volunteers to help properply translate these documents and correct the mistakes if anyone has any suggestions please let me know!

Changes proposed in this pull request:

  • Add 8 other most used languages on the internet to static i18n translation resources with initial
    rough translations from google tranlsate.

@ocBruno
feat(i18n): add translation resources
03729e5 
Add 8 other most used languages on the internet to static i18n translation resources with initial
rough translations from google tranlsate.
jackcmeyer
jackcmeyer reviewed Dec 13, 2019
View reviewed changes
Copy link
Member

@jackcmeyer jackcmeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an awesome pull request! Thanks for going through and doing this. It will be crucial to have these files continuously updated as new features get added

@fox1t
Copy link
Member

fox1t commented Dec 13, 2019

First of all, thanks for this PR! It is really appreciated :)

Secondly I think we need better folder and file structure. We can use "app sections" as top level folder and the inside it create language sub-folders. What do you think about that?

irvelervel
irvelervel previously approved these changes Jan 2, 2020
View reviewed changes
@matteovivona matteovivona requested review from irvelervel and jackcmeyer and removed request for matteovivona and irvelervel January 3, 2020 13:19
@matteovivona matteovivona added in progress indicates that issue/pull request is currently being worked on v2.x labels Jan 3, 2020
@matteovivona matteovivona added this to the v2.0.0 milestone Jan 3, 2020
@matteovivona matteovivona dismissed irvelervel’s stale review January 3, 2020 19:52

Structure changed since review

@matteovivona matteovivona removed the request for review from irvelervel January 3, 2020 19:53
jackcmeyer
jackcmeyer suggested changes Jan 4, 2020
View reviewed changes
Copy link
Member

@jackcmeyer jackcmeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As @fox1t mentioned, we should organize the translations by app sections.

For example instead of the app-sections folder there would be a patients folder and appointments folder.

@vercel
Copy link

vercel bot commented Jan 5, 2020 •
edited
Loading

This pull request is being automatically deployed with ZEIT Now (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://zeit.co/hospitalrun/hospitalrun-frontend/ilqprkh66
✅ Preview: https://hospitalrun-frontend-git-fork-ocbruno-add-translation-resources.hospitalrun.now.sh

@fox1t
Copy link
Member

fox1t commented Jan 31, 2020

Hello @jackcmeyer @fox1t @irvelervel and @tehkapa,
Despite a couple difficulties, I updated this branch and refactored the translations into their own separate folders as requested and fixed a couple test and lint issues along the way.
If anyone has any ideas on the next steps we should take to improve the integration of i18next and internationalization leave me a comment!

An idea I have is for the static resources we should gradually add the necessary translations with the help of other bilingual people. We can place a good first issue to leave pinned on the issues page which attracts new contributors worldwide with a simple first issue.

Nice idea. I completely agree that we need an issue to track all languages we support, where we can update a checklist (pinned). Then we will open an issue for a single language.

fox1t
fox1t reviewed Jan 31, 2020
View reviewed changes
src/components/Navbar.tsx Outdated Show resolved Hide resolved
jackcmeyer
jackcmeyer suggested changes Feb 2, 2020
View reviewed changes
Copy link
Member

@jackcmeyer jackcmeyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like there is some missing translations (check out the preview and you can see the ones that are missing)

@ocBruno
Copy link
Contributor Author

ocBruno commented Feb 2, 2020 •
edited
Loading

Looks like there is some missing translations (check out the preview and you can see the ones that are missing)

Hey @jackcmeyer,
I'm going to try to keep the english and portuguese translations up to date and I can help search for some bilingual contributors to help us out, create some good first issues or something along those lines.
Still have to fix some tests that are failing.

@matteovivona
Copy link
Contributor

@ocBruno any news?

@ocBruno
Copy link
Contributor Author

ocBruno commented Feb 11, 2020 •
edited
Loading

@ocBruno any news?

@tehkapa
I had updated english and portuguese to all necessary translations, not sure what else, if anyone has any other requests drop them here .
Just noticed the conflicting files so I will take a look at it later and resolve that later

@matteovivona matteovivona added the in progress indicates that issue/pull request is currently being worked on label Feb 18, 2020
@fox1t
Copy link
Member

fox1t commented Feb 27, 2020

@ocBruno Any news about this PR? I think this is a needed feature and you done a good job.

@ocBruno
Copy link
Contributor Author

ocBruno commented Feb 28, 2020

@ocBruno Any news about this PR? I think this is a needed feature and you done a good job.

Hey @fox1t,

I started working two weeks ago at a new company and have less free time, if someone wants to keep working on this feel free but for now I will be working on one issue at a time and I am trying to wrap up the input-validation on components library before returning to this one.

Last time I checked this I was unsure exactly what else was needed to finish. I think we should create an issue for separate languages for new contributors to do some translation for the static website data.

@fox1t
Copy link
Member

fox1t commented Mar 3, 2020

@ocBruno there is only one thing left to do: resolve the conflicts. After it, we can land it on master! :)

@matteovivona matteovivona mentioned this pull request Mar 9, 2020
Closed
@matteovivona matteovivona added the help wanted indicates that an issue is open for contributions label Mar 9, 2020
@matteovivona matteovivona self-requested a review March 9, 2020 14:13
@matteovivona matteovivona mentioned this pull request Mar 9, 2020
Closed
@jackcmeyer jackcmeyer self-requested a review March 10, 2020 01:27
@jackcmeyer
Copy link
Member

Moving this to #1892

@jackcmeyer jackcmeyer closed this Mar 10, 2020
@jackcmeyer jackcmeyer mentioned this pull request Mar 10, 2020
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@fox1t fox1t fox1t left review comments

@irvelervel irvelervel irvelervel left review comments

@matteovivona matteovivona Awaiting requested review from matteovivona

@jackcmeyer jackcmeyer Awaiting requested review from jackcmeyer

Assignees

@jackcmeyer jackcmeyer

Labels
help wanted indicates that an issue is open for contributions in progress indicates that issue/pull request is currently being worked on localization needs requirements indicates that an issue needs more requirements in order to be worked on v2.x
Projects
None yet
Milestone
v2.0
Development

Successfully merging this pull request may close these issues.
6 participants
@ocBruno @fox1t @jackcmeyer @jsf-clabot @matteovivona @irvelervel